weiqingy commented on PR #2376: URL: https://github.com/apache/auron/pull/2376#issuecomment-4889108359
Thanks @lyne7-sc — went through `7c69c06a` and all three are resolved. The shared `inspectFieldIdSupport` helper now carries the field-id extraction, rename/drop detection, and both asserts for the file-scan and changelog paths, parameterized by the two `scan → …` lookups — so a future field-id change lands on both paths at once. Since this bug came from those two paths drifting apart, folding them together is the durable fix. The note on `SparkChangelogScan`'s internal field-name reflection localizes the assumption and points the next Iceberg bump at the fallback, and the ORC top-level rename/drop comment now reads the same on both paths. Nothing further from me — the changes look good. I'll leave the final call to the maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
