slfan1989 commented on code in PR #2394:
URL: https://github.com/apache/auron/pull/2394#discussion_r3653814657
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -569,6 +569,7 @@ object NativeConverters extends Logging {
pb.PhysicalNegativeNode
.newBuilder()
.setExpr(convertExprWithFallback(unaryMinus.child,
isPruningExpr, fallback))
+ .setAnsiEnabled(SQLConf.get.ansiEnabled)
Review Comment:
Thanks for the contribution! Could we serialize `unaryMinus.failOnError`
instead of re-reading `SQLConf.get.ansiEnabled` here? Since Spark 3.1,
`UnaryMinus` carries its own `failOnError` value, which may differ from the
current session setting. Re-reading the configuration during native conversion
could change the expression’s semantics. Spark 3.0 can use a shim or fall back
to the SQLConf value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
