weimingdiit commented on code in PR #2424:
URL: https://github.com/apache/auron/pull/2424#discussion_r3671888075
##########
native-engine/datafusion-ext-plans/src/common/row_null_checker.rs:
##########
@@ -51,18 +60,33 @@ impl RowNullChecker {
/// * `NullBuffer` - Buffer indicating which rows contain null values
/// - `false` bits indicate rows that contain at least one null value
/// - `true` bits indicate rows where all fields are non-null
Review Comment:
Good point. I updated the documentation to include row_converter and clarify
that it must be the RowConverter that produced rows, as required by
RowConverter::convert_rows.
I also changed the validity description to refer explicitly to top-level key
fields, so it does not imply that nested nulls inside a valid struct make the
key null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
