zuston opened a new issue, #2446:
URL: https://github.com/apache/auron/issues/2446

   ### Description
   
   `BufferedData::add_batch` uses `compute_suggested_batch_size_for_output` to 
determine when staged record batches should be sorted and flushed.
   
   However, `compute_suggested_batch_size_for_output(mem_size, num_rows)` 
returns a suggested number of rows, while the current condition compares that 
value with `staging_mem_used`, which is measured in bytes:
   
   ```rust
   let suggested_batch_size =
       compute_suggested_batch_size_for_output(
           self.staging_mem_used,
           self.staging_num_rows,
       );
   
   if self.staging_mem_used > suggested_batch_size {
       self.flush_staging()?;
   }
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to