weiqingy commented on code in PR #2409: URL: https://github.com/apache/auron/pull/2409#discussion_r3707345377
########## native-engine/datafusion-ext-functions/src/flink_datetime.rs: ########## @@ -0,0 +1,637 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +use std::sync::Arc; + +use arrow::{ + array::{Int64Array, StringArray}, + datatypes::DataType, +}; +use chrono::{DateTime, LocalResult, NaiveDateTime, Offset, TimeZone}; +use chrono_tz::{OffsetComponents, Tz}; +use datafusion::{ + common::{DataFusionError, Result, ScalarValue}, + physical_plan::ColumnarValue, +}; +use datafusion_ext_commons::arrow::cast::cast; + +/// Native implementation of Flink SQL `UNIX_TIMESTAMP(value, format)`: parse a +/// formatted date-time string to a Unix timestamp in seconds, replicating +/// `java.text.SimpleDateFormat` lenient semantics. +/// +/// Arguments are always `[value, chronoFormat, zoneId]` (arity 3). `value` is +/// the column of strings to parse; `chronoFormat` and `zoneId` are literal +/// scalars bound at plan time. The format is a `%`-specifier string built by +/// the JVM-side converter from `%Y %m %d %H %M %S` plus literal characters +/// (`%%` for a literal percent) — it is not the original Java pattern. +/// +/// An unparseable value yields `i64::MIN` (Flink's `Long.MIN_VALUE`), never +/// NULL and never an error; a NULL value yields NULL. Arity, format and +/// timezone problems are hard errors rather than silent defaults, so a plumbing +/// bug cannot surface as silently wrong data. +pub fn flink_unix_timestamp(args: &[ColumnarValue]) -> Result<ColumnarValue> { + if args.len() != 3 { Review Comment: Thanks for the review and the approval. Both are on the Java side, and this PR is native only, so I've made them on the converter change (weiqingy/auron#1, which opens here once this one merges). Note: the arity-3 contract and the 0-argument exclusion are now documented in the javadoc on `isUnixTimestampSupported` and `buildUnixTimestamp`, instead of only in this thread. Validation: the zero-argument form is now rejected explicitly in `isUnixTimestampSupported`, and `buildUnixTimestamp` throws `IllegalArgumentException` if it ever gets anything other than 1 or 2 arguments, same as the native function's own arity check. `testUnixTimestampZeroArgFallsBack` covers both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
