weimingdiit commented on PR #2406: URL: https://github.com/apache/auron/pull/2406#issuecomment-5188179912
@yew1eb Thanks for the optimization.I have a additional questions: Could we add correctness coverage for the other advertised primitive types? The fast path currently includes signed/unsigned integers, Date32/Date64, and Timestamp, but the tests primarily exercise Int64. A small parameterized test covering at least one unsigned type, one date type, and one timestamp type would help validate Arrow ordering semantics. It would also be useful to combine a nullable key, a payload column, and Top-N in one case to verify both null ordering and payload alignment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
