slfan1989 commented on code in PR #2445:
URL: https://github.com/apache/auron/pull/2445#discussion_r3765217240
##########
auron-build.sh:
##########
@@ -529,6 +533,8 @@ mkdir -p "$(dirname "$BUILD_INFO_FILE")"
JAVA_VERSION=$(java -version 2>&1 | head -n 1 | awk '{print $3}' | tr -d '"')
PROJECT_VERSION=$(./build/mvn help:evaluate -N -Dexpression=project.version
-Pspark-${SPARK_VER} -q -DforceStdout 2>/dev/null)
RUST_VERSION=$(rustc --version | awk '{print $2}')
+BUILD_BRANCH="${AURON_BUILD_BRANCH:-$(git rev-parse --abbrev-ref HEAD
2>/dev/null)}"
Review Comment:
Thanks for adding the override and forwarding it into Docker. However, none
of the workflows currently sets `AURON_BUILD_BRANCH`, so release jobs that
check out `${{ github.event.pull_request.head.sha }}` still fall back to `git
rev-parse` and record `build.branch=HEAD`. Please populate the override in the
relevant workflows, for example with `${{ github.head_ref || github.ref_name
}}`. The revision override could similarly use `${{
github.event.pull_request.head.sha || github.sha }}` to make the recorded
source explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
