slfan1989 commented on code in PR #2452:
URL: https://github.com/apache/auron/pull/2452#discussion_r3788194176


##########
thirdparty/auron-paimon/src/test/scala/org/apache/auron/paimon/AuronPaimonV2IntegrationSuite.scala:
##########
@@ -143,6 +143,24 @@ class AuronPaimonV2IntegrationSuite
     }
   }
 
+  test("paimon v2 COW primary-key table preserves latest value across 
commits") {
+    withTable("paimon.db.t_cow_multi_commit") {
+      sql("""
+            |create table paimon.db.t_cow_multi_commit (id int, v string)
+            |using paimon
+            |tblproperties (
+            |  'primary-key' = 'id',
+            |  'bucket' = '2',
+            |  'full-compaction.delta-commits' = '1'
+            |)
+            |""".stripMargin)
+      sql("insert into paimon.db.t_cow_multi_commit values (1, 'a'), (2, 'b')")
+      sql("insert into paimon.db.t_cow_multi_commit values (1, 'updated')")
+      val df = sql("select * from paimon.db.t_cow_multi_commit")
+      checkAnswer(df, Seq(Row(1, "updated"), Row(2, "b")))

Review Comment:
   Thanks for adding the multi-commit COW coverage. I agree with the existing 
review comment: the test should also call `assertNativePaimonScanApplied(df)`, 
otherwise it can pass through Spark fallback without exercising the native 
path. Please address that before merging.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to