slfan1989 commented on code in PR #2462: URL: https://github.com/apache/auron/pull/2462#discussion_r3788223679
########## auron-build.sh: ########## Review Comment: The passthrough arguments remaining in `"$@"` are only forwarded by the local Maven invocation. Docker mode exports `BUILD_ARGS` alone, so arguments after `--` are silently dropped. Please forward the passthrough arguments into the container as well, while preserving argument boundaries, or explicitly reject/document passthrough as unsupported in Docker mode. ########## auron-build.sh: ########## Review Comment: `--mvn` is intended to bypass `build/mvn` for offline or air-gapped builds, but project-version resolution still invokes `./build/mvn` directly. Please use `"$MVN_CMD"` here as well; otherwise this step may still trigger the wrapper’s download path and fail offline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
