xiaoyanxie commented on code in PR #2395:
URL: https://github.com/apache/auron/pull/2395#discussion_r3817805146
##########
.github/workflows/tpcds-reusable.yml:
##########
@@ -380,13 +403,30 @@ jobs:
SPARK_HOME: spark-bin-${{ inputs.sparkver }}_${{ inputs.scalaver }}
run: |
ls -la
+ set -o pipefail
dev/auron-it/run-it.sh \
${{ inputs.extrasparkconf }} \
--type tpcds \
--data-location dev/tpcds_1g \
--query-filter ${{ matrix.query }} \
--result-check \
- --plan-check
+ --plan-check 2>&1 | tee tpcds-run-${{ matrix.query }}.log
Review Comment:
You are right about --plan-check. PlanStabilityChecker returns early for any
version except spark-3.5. In my local run it just prints:
```
[PlanCheck] Unsupported Spark version: spark-4.1. Skipping.
```
So the job had no positive check at all. If the optimizer stops generating
this plan, the job would still pass and we would not notice.
I added --print-plan to auron-it, and a new assert-log-matches input. For
this job it is set to `might_contain`, which is the runtime bloom filter probe.
In my local q1–q3 run it appears 10 times, and now the job will fail if it
disappears.
This does not add extra cost. `QueryRunner` already builds the plan string
every time, so the new flag only decides whether to print it.
See commit
[e2dc0b3](https://github.com/apache/auron/pull/2395/changes/e2dc0b308eaa6657a4a40101736a176bbdd12ff8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
