Repository: aurora Updated Branches: refs/heads/master f56ea265c -> 9dd80a439
Added a note for committers on formatting commit messages generated by ./rbt patch Reviewed at https://reviews.apache.org/r/41743/ Project: http://git-wip-us.apache.org/repos/asf/aurora/repo Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/9dd80a43 Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/9dd80a43 Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/9dd80a43 Branch: refs/heads/master Commit: 9dd80a439a3d99117b2ab25af26ee57c29a61772 Parents: f56ea26 Author: Joshua Cohen <[email protected]> Authored: Mon Dec 28 11:15:44 2015 -0600 Committer: Joshua Cohen <[email protected]> Committed: Mon Dec 28 11:15:44 2015 -0600 ---------------------------------------------------------------------- CONTRIBUTING.md | 7 +++++++ 1 file changed, 7 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/aurora/blob/9dd80a43/CONTRIBUTING.md ---------------------------------------------------------------------- diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 59ac829..13ebbe4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -77,6 +77,13 @@ Sometimes you'll need to merge someone else's RB. The typical workflow for this git show master # Verify everything looks sane, author is correct git push origin master +Note for committers: while we generally use the commit message generated by `./rbt patch` some +changes are often required: + +1. Ensure the the commit message does not exceed 100 characters per line. +2. Remove the "Testing Done" section. It's generally redundant (can be seen by checking the linked + review) or entirely irrelevant to the commit itself. + ## Cleaning Up Your patch has landed, congratulations! The last thing you'll want to do before moving on to your
