Repository: aurora Updated Branches: refs/heads/master 9b34a4036 -> c115ac6bc
Only warn about terminated executors if their exit code is not 0. I have left a comment in the corresponding Mesos issue MESOS-313, so hopefully we can remove that guard here in the future. Bugs closed: AURORA-1719 Reviewed at https://reviews.apache.org/r/51306/ Project: http://git-wip-us.apache.org/repos/asf/aurora/repo Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/c115ac6b Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/c115ac6b Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/c115ac6b Branch: refs/heads/master Commit: c115ac6bc072f62c94dc6b8209e251322814b216 Parents: 9b34a40 Author: Stephan Erb <[email protected]> Authored: Tue Aug 23 18:15:53 2016 +0200 Committer: Stephan Erb <[email protected]> Committed: Tue Aug 23 18:15:53 2016 +0200 ---------------------------------------------------------------------- .../apache/aurora/scheduler/mesos/MesosSchedulerImpl.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/aurora/blob/c115ac6b/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java b/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java index df87d92..d63bfc1 100644 --- a/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java +++ b/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java @@ -254,9 +254,12 @@ public class MesosSchedulerImpl implements Scheduler { @Override public void executorLost(SchedulerDriver schedulerDriver, ExecutorID executorID, SlaveID slaveID, int status) { - - log.warn("Lost executor " + executorID + " on slave " + slaveID); - counters.get("scheduler_lost_executors").incrementAndGet(); + // With the current implementation of MESOS-313, Mesos is also reporting clean terminations of + // custom executors via the executorLost callback. + if (status != 0) { + log.warn("Lost executor " + executorID + " on slave " + slaveID + " with status " + status); + counters.get("scheduler_lost_executors").incrementAndGet(); + } } @Timed("scheduler_framework_message")
