Repository: aurora Updated Branches: refs/heads/master c4903d873 -> f0ff1c4fb
Implement `toString` on lazy modules. This will change the help output from: `-shiro_realm_modules (default [org.apache.aurora.scheduler.app.MoreModules$1@158a8276])` to `-shiro_realm_modules (default [class org.apache.aurora.scheduler.http.api.security.IniShiroRealmModule])` Bugs closed: AURORA-1770 Reviewed at https://reviews.apache.org/r/51826/ Project: http://git-wip-us.apache.org/repos/asf/aurora/repo Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/f0ff1c4f Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/f0ff1c4f Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/f0ff1c4f Branch: refs/heads/master Commit: f0ff1c4fb43e57b647408aa32bfb0351e8407a2b Parents: c4903d8 Author: Zameer Manji <[email protected]> Authored: Mon Sep 12 16:30:17 2016 -0700 Committer: Zameer Manji <[email protected]> Committed: Mon Sep 12 16:30:17 2016 -0700 ---------------------------------------------------------------------- .../java/org/apache/aurora/scheduler/app/MoreModules.java | 5 +++++ .../java/org/apache/aurora/scheduler/app/MoreModulesTest.java | 7 +++++++ 2 files changed, 12 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/aurora/blob/f0ff1c4f/src/main/java/org/apache/aurora/scheduler/app/MoreModules.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/aurora/scheduler/app/MoreModules.java b/src/main/java/org/apache/aurora/scheduler/app/MoreModules.java index d5f9654..074f220 100644 --- a/src/main/java/org/apache/aurora/scheduler/app/MoreModules.java +++ b/src/main/java/org/apache/aurora/scheduler/app/MoreModules.java @@ -63,6 +63,11 @@ public final class MoreModules { protected void configure() { install(getModule(moduleClass)); } + + @Override + public String toString() { + return moduleClass.toString(); + } }; } } http://git-wip-us.apache.org/repos/asf/aurora/blob/f0ff1c4f/src/test/java/org/apache/aurora/scheduler/app/MoreModulesTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/aurora/scheduler/app/MoreModulesTest.java b/src/test/java/org/apache/aurora/scheduler/app/MoreModulesTest.java index b2fb3c9..1b23948 100644 --- a/src/test/java/org/apache/aurora/scheduler/app/MoreModulesTest.java +++ b/src/test/java/org/apache/aurora/scheduler/app/MoreModulesTest.java @@ -16,6 +16,7 @@ package org.apache.aurora.scheduler.app; import com.google.inject.AbstractModule; import com.google.inject.Guice; import com.google.inject.Injector; +import com.google.inject.Module; import org.junit.Test; @@ -30,6 +31,12 @@ public class MoreModulesTest { assertEquals(STRING, injector.getInstance(String.class)); } + @Test + public void testToString() { + Module module = MoreModules.lazilyInstantiated(StringInstaller.class); + assertEquals(StringInstaller.class.toString(), module.toString()); + } + static class StringInstaller extends AbstractModule { @Override protected void configure() {
