Update PMD and checkstyle. This updates PMD to 5.5.2 and checkstyle to 7.3. The included code change was reported by the latest PMD version, i.e. exceptions will be picked up automatically. There is no need for a placeholder.
Changelogs: * https://pmd.github.io/pmd-5.5.2/overview/changelog.html * http://checkstyle.sourceforge.net/releasenotes.html Reviewed at https://reviews.apache.org/r/54176/ Project: http://git-wip-us.apache.org/repos/asf/aurora/repo Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/4e46fd89 Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/4e46fd89 Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/4e46fd89 Branch: refs/heads/master Commit: 4e46fd892e7a55c3c5ea7d1f95533c19310bcb95 Parents: c8135c0 Author: Stephan Erb <s...@apache.org> Authored: Wed Nov 30 09:44:17 2016 +0100 Committer: Stephan Erb <s...@apache.org> Committed: Wed Nov 30 09:44:17 2016 +0100 ---------------------------------------------------------------------- build.gradle | 4 ++-- .../org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/aurora/blob/4e46fd89/build.gradle ---------------------------------------------------------------------- diff --git a/build.gradle b/build.gradle index a586ad0..f257440 100644 --- a/build.gradle +++ b/build.gradle @@ -414,7 +414,7 @@ codeQualityTasks.each { checkstyle { sourceSets = [sourceSets.main , sourceSets.test, sourceSets.jmh] - toolVersion = '6.13' + toolVersion = '7.3' } findbugs { @@ -432,7 +432,7 @@ tasks.withType(FindBugs) { } pmd { - toolVersion = '5.4.1' + toolVersion = '5.5.2' consoleOutput = true } http://git-wip-us.apache.org/repos/asf/aurora/blob/4e46fd89/src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java b/src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java index 7c8047a..ae7d019 100644 --- a/src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java +++ b/src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java @@ -173,7 +173,7 @@ class AuroraCronJob implements Job, EventSubscriber { try { cronJob = SanitizedCronJob.fromUnsanitized(configurationManager, config.get()); } catch (ConfigurationManager.TaskDescriptionException | CronException e) { - LOG.warn("Invalid cron job for {} in storage - failed to parse with {}", key, e); + LOG.warn("Invalid cron job for {} in storage - failed to parse", key, e); CRON_JOB_PARSE_FAILURES.incrementAndGet(); return BatchWorker.NO_RESULT; }
