Repository: aurora Updated Branches: refs/heads/master a94601acc -> cffa5bac9
Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path. Bugs closed: AURORA-1878 Reviewed at https://reviews.apache.org/r/55434/ Project: http://git-wip-us.apache.org/repos/asf/aurora/repo Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/cffa5bac Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/cffa5bac Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/cffa5bac Branch: refs/heads/master Commit: cffa5bac9b2df4fad916a522e47188b57b314c6d Parents: a94601a Author: Joshua Cohen <[email protected]> Authored: Wed Jan 11 16:19:49 2017 -0600 Committer: Joshua Cohen <[email protected]> Committed: Wed Jan 11 16:19:49 2017 -0600 ---------------------------------------------------------------------- src/main/python/apache/aurora/executor/common/status_checker.py | 2 +- src/main/python/apache/aurora/executor/status_manager.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/aurora/blob/cffa5bac/src/main/python/apache/aurora/executor/common/status_checker.py ---------------------------------------------------------------------- diff --git a/src/main/python/apache/aurora/executor/common/status_checker.py b/src/main/python/apache/aurora/executor/common/status_checker.py index f278825..d491ef9 100644 --- a/src/main/python/apache/aurora/executor/common/status_checker.py +++ b/src/main/python/apache/aurora/executor/common/status_checker.py @@ -118,7 +118,6 @@ class ChainedStatusChecker(StatusChecker): for status_checker in self._status_checkers: status_result = status_checker.status if status_result is not None: - log.info('%s reported %s' % (status_checker.__class__.__name__, status_result)) if not isinstance(status_result, StatusResult): raise TypeError('StatusChecker returned something other than a StatusResult: got %s' % type(status_result)) @@ -131,6 +130,7 @@ class ChainedStatusChecker(StatusChecker): cur_status = status_result else: # Any other status leads to a terminal state + log.info('%s reported %s', status_checker.__class__.__name__, status_result) self._status = status_result return self._status self._status = cur_status http://git-wip-us.apache.org/repos/asf/aurora/blob/cffa5bac/src/main/python/apache/aurora/executor/status_manager.py ---------------------------------------------------------------------- diff --git a/src/main/python/apache/aurora/executor/status_manager.py b/src/main/python/apache/aurora/executor/status_manager.py index 8b536a9..bd4cc49 100644 --- a/src/main/python/apache/aurora/executor/status_manager.py +++ b/src/main/python/apache/aurora/executor/status_manager.py @@ -53,12 +53,13 @@ class StatusManager(ExceptionalThread): while True: status_result = self._status_checker.status if status_result is not None: - log.info('Status manager got %s' % status_result) if status_result.status == TaskState.Value('TASK_RUNNING'): if not self._running_callback_dispatched: self._running_callback(status_result) self._running_callback_dispatched = True elif status_result.status != TaskState.Value('TASK_STARTING'): + log.info('Status manager got unhealthy status: %s' % status_result) self._unhealthy_callback(status_result) break + self._clock.sleep(self.POLL_WAIT.as_(Time.SECONDS))
