AVRO-2054: Use StringBuilder instead of StringBuffer
Project: http://git-wip-us.apache.org/repos/asf/avro/repo Commit: http://git-wip-us.apache.org/repos/asf/avro/commit/224f75f6 Tree: http://git-wip-us.apache.org/repos/asf/avro/tree/224f75f6 Diff: http://git-wip-us.apache.org/repos/asf/avro/diff/224f75f6 Branch: refs/heads/master Commit: 224f75f64982fa65c56039e4c413b5d9c138800b Parents: 3801888 Author: BELUGA BEHR <[email protected]> Authored: Thu Jul 27 09:47:27 2017 +0200 Committer: Gabor Szadovszky <[email protected]> Committed: Thu Jul 27 10:17:44 2017 +0200 ---------------------------------------------------------------------- CHANGES.txt | 3 +++ .../src/main/java/org/apache/trevni/MetaData.java | 16 ++++++++-------- 2 files changed, 11 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/avro/blob/224f75f6/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index d06aa3e..661e565 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -61,6 +61,9 @@ Trunk (not yet released) AVRO-2056: DirectBinaryEncoder Creates Buffer For Each Call To writeDouble (Beluga Behr via gabor) + AVRO-2054: Use StringBuilder instead of StringBuffer + (Beluga Behr via gabor) + BUG FIXES AVRO-1741: Python3: Fix error when codec is not in the header. http://git-wip-us.apache.org/repos/asf/avro/blob/224f75f6/lang/java/trevni/core/src/main/java/org/apache/trevni/MetaData.java ---------------------------------------------------------------------- diff --git a/lang/java/trevni/core/src/main/java/org/apache/trevni/MetaData.java b/lang/java/trevni/core/src/main/java/org/apache/trevni/MetaData.java index 08d0072..f009623 100644 --- a/lang/java/trevni/core/src/main/java/org/apache/trevni/MetaData.java +++ b/lang/java/trevni/core/src/main/java/org/apache/trevni/MetaData.java @@ -126,20 +126,20 @@ public class MetaData<T extends MetaData> extends LinkedHashMap<String,byte[]> { } @Override public String toString() { - StringBuffer buffer = new StringBuffer(); - buffer.append("{ "); + StringBuilder builder = new StringBuilder(); + builder.append('{').append(' '); for (Map.Entry<String,byte[]> e : entrySet()) { - buffer.append(e.getKey()); - buffer.append("="); + builder.append(e.getKey()); + builder.append('='); try { - buffer.append(new String(e.getValue(), "ISO-8859-1")); + builder.append(new String(e.getValue(), "ISO-8859-1")); } catch (java.io.UnsupportedEncodingException error) { throw new TrevniRuntimeException(error); } - buffer.append(" "); + builder.append(' '); } - buffer.append("}"); - return buffer.toString(); + builder.append('}'); + return builder.toString(); } }
