This is an automated email from the ASF dual-hosted git repository.

iemejia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git


The following commit(s) were added to refs/heads/master by this push:
     new bcc79e9  AVRO-2309: Conversions.java - Use JDK Array Manipulations
bcc79e9 is described below

commit bcc79e90540f55dc9e1dd34da7a1f5901ee22b2a
Author: Beluga Behr <[email protected]>
AuthorDate: Mon Jan 28 12:21:57 2019 -0500

    AVRO-2309: Conversions.java - Use JDK Array Manipulations
---
 lang/java/avro/src/main/java/org/apache/avro/Conversions.java | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/lang/java/avro/src/main/java/org/apache/avro/Conversions.java 
b/lang/java/avro/src/main/java/org/apache/avro/Conversions.java
index 0456580..08c5e24 100644
--- a/lang/java/avro/src/main/java/org/apache/avro/Conversions.java
+++ b/lang/java/avro/src/main/java/org/apache/avro/Conversions.java
@@ -114,13 +114,9 @@ public class Conversions {
       byte[] bytes = new byte[schema.getFixedSize()];
       int offset = bytes.length - unscaled.length;
 
-      for (int i = 0; i < bytes.length; i += 1) {
-        if (i < offset) {
-          bytes[i] = fillByte;
-        } else {
-          bytes[i] = unscaled[i - offset];
-        }
-      }
+      // Fill the front of the array and copy remaining with unscaled values
+      Arrays.fill(bytes, 0, offset, fillByte);
+      System.arraycopy(unscaled, 0, bytes, offset, bytes.length - offset);
 
       return new GenericData.Fixed(schema, bytes);
     }

Reply via email to