This is an automated email from the ASF dual-hosted git repository.

iemejia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git


The following commit(s) were added to refs/heads/master by this push:
     new f9f6cdec6 AVRO-3411: Fix devcontainers build (#2504)
f9f6cdec6 is described below

commit f9f6cdec615cab79f597195727529a5354356540
Author: Ismaël Mejía <[email protected]>
AuthorDate: Wed Sep 20 16:17:20 2023 +0200

    AVRO-3411: Fix devcontainers build (#2504)
---
 .devcontainer/devcontainer.json | 70 +++++++++++++++++++----------------------
 README.md                       |  6 ++++
 2 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index b45b4d47b..bb261cfd8 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -1,42 +1,36 @@
 {
     "name": "Avro Development",
-
-    "build": { "dockerfile": "../share/docker/Dockerfile" },
-
-    // Use 'settings' to set *default* container specific settings.json values 
on container create.
-    // You can edit these settings after create using File > Preferences > 
Settings > Remote.
-    "settings": {
+    "build": {
+        "dockerfile": "../share/docker/Dockerfile",
+        "context": ".."
     },
-
-    // Add the IDs of extensions you want installed when the container is 
created in the array below.
-    "extensions": [
-        // Python
-        "ms-python.python",
-        "ms-python.vscode-pylance",
-
-         // C/C++
-        "ms-vscode.cpptools",
-
-        // C#
-        "ms-dotnettools.csharp",
-
-        // Rust
-        "vadimcn.vscode-lldb",
-        "mutantdino.resourcemonitor",
-        "matklad.rust-analyzer",
-        "tamasfe.even-better-toml",
-        "serayuzgur.crates",
-
-        // Java
-        "vscjava.vscode-java-pack",
-
-        // Shell script
-        "timonwong.shellcheck",
-
-        // YAML
-        "redhat.vscode-yaml",
-
-        // Git
-        "eamodio.gitlens"
-    ]
+    "customizations": {
+        "vscode": {
+            "settings": {
+            },
+            "extensions": [
+                // Python
+                "ms-python.python",
+                "ms-python.vscode-pylance",
+                // C/C++
+                "ms-vscode.cpptools",
+                // C#
+                "ms-dotnettools.csharp",
+                // Rust
+                "vadimcn.vscode-lldb",
+                "mutantdino.resourcemonitor",
+                "matklad.rust-analyzer",
+                "tamasfe.even-better-toml",
+                "serayuzgur.crates",
+                // Java
+                "vscjava.vscode-java-pack",
+                // Shell script
+                "timonwong.shellcheck",
+                // YAML
+                "redhat.vscode-yaml",
+                // Git
+                "eamodio.gitlens"
+            ]
+        }
+    }
 }
\ No newline at end of file
diff --git a/README.md b/README.md
index 472656a3e..d88287518 100644
--- a/README.md
+++ b/README.md
@@ -70,3 +70,9 @@ To contribute to Avro, please read:
 [codeql java img]:       
https://github.com/apache/avro/actions/workflows/codeql-java-analysis.yml/badge.svg
 [codeql javascript img]: 
https://github.com/apache/avro/actions/workflows/codeql-js-analysis.yml/badge.svg
 [codeql python img]:     
https://github.com/apache/avro/actions/workflows/codeql-py-analysis.yml/badge.svg
+
+You can use devcontainers to develop Avro:
+
+* [![Open in Visual Studio 
Code](https://img.shields.io/static/v1?label=&message=Open%20in%20Visual%20Studio%20Code&color=blue&logo=visualstudiocode&style=flat)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/apache/avro)
+* [![Open in Github 
Codespaces](https://img.shields.io/static/v1?label=&message=Open%20in%20Github%20Codespaces&color=2f362d&logo=github)](https://codespaces.new/apache/avro?quickstart=1&hide_repo_select=true)
+

Reply via email to