bchapuis commented on code in PR #658:
URL:
https://github.com/apache/incubator-baremaps/pull/658#discussion_r1195332815
##########
.run/extrusion-create.run.xml:
##########
@@ -4,6 +4,11 @@
<module name="baremaps-cli" />
<option name="PROGRAM_PARAMETERS" value="workflow execute --file
workflow.json" />
<option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/examples/extrusion"
/>
+ <extension
name="software.aws.toolkits.jetbrains.core.execution.JavaAwsConnectionExtension">
Review Comment:
This section has probably been automatically added by IntelliJ.
##########
.run/geocoder-serve.run.xml:
##########
@@ -6,6 +6,11 @@
<module name="baremaps-cli" />
<option name="PROGRAM_PARAMETERS" value="geocoder serve --index
geocoder-index --port 9000" />
<option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/examples/geocoding"
/>
+ <extension
name="software.aws.toolkits.jetbrains.core.execution.JavaAwsConnectionExtension">
Review Comment:
Same here.
##########
.run/geocoder-create.run.xml:
##########
@@ -4,8 +4,13 @@
<module name="baremaps-cli" />
<option name="PROGRAM_PARAMETERS" value="workflow execute --file
workflow.js" />
<option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/examples/geocoding"
/>
+ <extension
name="software.aws.toolkits.jetbrains.core.execution.JavaAwsConnectionExtension">
Review Comment:
Same here.
##########
.run/iploc-serve.run.xml:
##########
@@ -4,8 +4,13 @@
<module name="baremaps-cli" />
<option name="PROGRAM_PARAMETERS" value="iploc serve --database iploc.db
--port 9000" />
<option name="WORKING_DIRECTORY"
value="$PROJECT_DIR$/examples/ip-to-location" />
+ <extension
name="software.aws.toolkits.jetbrains.core.execution.JavaAwsConnectionExtension">
Review Comment:
Same here.
##########
.run/naturalearth-dev.run.xml:
##########
@@ -2,8 +2,13 @@
<configuration default="false" name="naturalearth-dev" type="Application"
factoryName="Application">
<option name="MAIN_CLASS_NAME" value="org.apache.baremaps.cli.Baremaps" />
<module name="baremaps-cli" />
- <option name="PROGRAM_PARAMETERS" value="map dev --database
jdbc:postgresql://localhost:5432/baremaps?user=baremaps&password=baremaps
--tileset tileset.json --style style.json" />
+ <option name="PROGRAM_PARAMETERS" value="map dev --tileset tileset.json
--style style.json" />
<option name="WORKING_DIRECTORY"
value="$PROJECT_DIR$/examples/naturalearth" />
+ <extension
name="software.aws.toolkits.jetbrains.core.execution.JavaAwsConnectionExtension">
Review Comment:
Same here.
##########
baremaps-cli/src/main/java/org/apache/baremaps/cli/map/Dev.java:
##########
@@ -64,11 +60,13 @@ public class Dev implements Callable<Integer> {
@Override
public Integer call() throws Exception {
- try (var dataSource = PostgresUtils.dataSource(database)) {
+ // Configure serialization
+ var objectMapper = objectMapper();
- // Configure serialization
- var objectMapper = objectMapper();
+ var tileSet = objectMapper.readValue(tileset.toFile(), Tileset.class);
Review Comment:
Not directly linked to this issue, but I realize that the dev mode does not
support javascript configuration files. Here is an
[example](https://github.com/apache/incubator-baremaps/blob/1bae9022ec49b192cfb7ed3db2c133c29d9d2353/baremaps-cli/src/main/java/org/apache/baremaps/cli/map/Serve.java#L73)
of how the serve command works. The ConfigReader reads or executes the
configuration file, then it deserializes it.
##########
.run/extrusion-dev.run.xml:
##########
@@ -2,8 +2,13 @@
<configuration default="false" name="extrusion-dev" type="Application"
factoryName="Application">
<option name="MAIN_CLASS_NAME" value="org.apache.baremaps.cli.Baremaps" />
<module name="baremaps-cli" />
- <option name="PROGRAM_PARAMETERS" value="map dev --database
jdbc:postgresql://localhost:5432/baremaps?user=baremaps&password=baremaps
--tileset tileset.json --style style.json" />
+ <option name="PROGRAM_PARAMETERS" value="map dev --tileset tileset.json
--style style.json" />
<option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/examples/extrusion"
/>
+ <extension
name="software.aws.toolkits.jetbrains.core.execution.JavaAwsConnectionExtension">
Review Comment:
Same here.
##########
.run/naturalearth-create.run.xml:
##########
@@ -4,6 +4,11 @@
<module name="baremaps-cli" />
<option name="PROGRAM_PARAMETERS" value="workflow execute --file
workflow.json" />
<option name="WORKING_DIRECTORY"
value="$PROJECT_DIR$/examples/naturalearth" />
+ <extension
name="software.aws.toolkits.jetbrains.core.execution.JavaAwsConnectionExtension">
Review Comment:
Same here.
##########
.run/iploc-create.run.xml:
##########
@@ -4,8 +4,13 @@
<module name="baremaps-cli" />
<option name="PROGRAM_PARAMETERS" value="workflow execute --file
workflow.js" />
<option name="WORKING_DIRECTORY"
value="$PROJECT_DIR$/examples/ip-to-location" />
+ <extension
name="software.aws.toolkits.jetbrains.core.execution.JavaAwsConnectionExtension">
Review Comment:
Same here.
##########
baremaps-server/src/main/java/org/apache/baremaps/server/TileJSON/Field.java:
##########
@@ -0,0 +1,16 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
use this file except
+ * in compliance with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.baremaps.server.TileJSON;
+
+public class Field {
Review Comment:
Out of curiosity, what is a field? Does it acts as a placeholder?
##########
baremaps-server/src/main/java/org/apache/baremaps/server/TileJSON/Field.java:
##########
@@ -0,0 +1,16 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
use this file except
+ * in compliance with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.baremaps.server.TileJSON;
Review Comment:
According to oracle the package names should be lower case.
https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
