Perdjesk commented on code in PR #658:
URL:
https://github.com/apache/incubator-baremaps/pull/658#discussion_r1196377103
##########
baremaps-cli/src/main/java/org/apache/baremaps/cli/map/Dev.java:
##########
@@ -64,11 +60,13 @@ public class Dev implements Callable<Integer> {
@Override
public Integer call() throws Exception {
- try (var dataSource = PostgresUtils.dataSource(database)) {
+ // Configure serialization
+ var objectMapper = objectMapper();
- // Configure serialization
- var objectMapper = objectMapper();
+ var tileSet = objectMapper.readValue(tileset.toFile(), Tileset.class);
Review Comment:
It seems to me that this a regression with this change. All others places
including `DevResources.java` are reading the file always through the
`ConfigReader`. It was overlooked because, I missed that it was required due to
the underlying `--tilset` file supporting to be JS or plain JSON.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
