bchapuis commented on code in PR #690:
URL:
https://github.com/apache/incubator-baremaps/pull/690#discussion_r1219303235
##########
basemap/utils/utils.js:
##########
@@ -216,6 +227,56 @@ function mergeInterpolatedDirective(directives, property,
alias, value) {
}
}
+function mergeInterpolatedDupletColorDirective(directives, property, alias,
startZoom, endZoom, fallback) {
Review Comment:
Duplet is a musical term, right? ;) and the value of the property may or may
not be a tuple. Maybe, `mergeInterpolatedColorDirective` is a more suitable
name. What do you think?
##########
basemap/utils/utils.js:
##########
@@ -216,6 +227,56 @@ function mergeInterpolatedDirective(directives, property,
alias, value) {
}
}
+function mergeInterpolatedDupletColorDirective(directives, property, alias,
startZoom, endZoom, fallback) {
+ let cases = []
Review Comment:
What about:
```javascript
let cases = directives.map((rule) => ...)
```
It is better to avoid side effects when doing functional programming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
