github-code-scanning[bot] commented on code in PR #691: URL: https://github.com/apache/incubator-baremaps/pull/691#discussion_r1226963736
########## basemap/themes/light.js: ########## @@ -0,0 +1,53 @@ +import style from './default.js'; Review Comment: ## Unused variable, import, function or class Unused import style. [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/667) ########## basemap/themes/light.js: ########## @@ -0,0 +1,53 @@ +import style from './default.js'; +import * as importedTools from "./tools.js"; +import positronScheme from "./positron.js"; + +const CLARITYFACTOR=4.7; + + +function lightScheme(string){ + const table=importedTools.cutRgbString(string); + if(table[1]!=null){ + let newColor=importedTools.max-importedTools.clamp(table[0]/CLARITYFACTOR); + return importedTools.giveNewColorString(table, newColor, newColor, newColor); + } + return null; +} + +export default Object.entries(positronScheme).reduce((acc, [key, value]) => { + acc[key] = lightScheme(value); + return {...acc, + pointCountryLabelCountryTextColor: 'rgb(90, 56, 90)', + pointCountryLabelPaintTextHaloColor: 'rgba(255, 255, 255, 0.8)', + pointLabelCityLabelColor: 'rgb(25, 25, 25)', + pointLabelCityFilterOneLabelColor: 'rgb(100, 100, 100)', + pointLabelCityFilterTwoLabelColor: 'rgb(50, 50, 50)', + pointLabelTownFilterOneLabelColor: 'rgb(100, 100, 100)', + pointLabelTownFilterTwoLabelColor: 'rgb(75, 75, 75)', + pointLabelVillageLabelColor: 'rgb(100, 100, 100)', + pointLabelLocalityLabelColor: 'rgb(100, 100, 100)', + pointLabelPlaceTextColor: 'rgba(100, 100, 100, 1)', + pointLabelPaintTextHaloColor: 'rgba(255, 255, 255, 0.8)', + + naturalBackgroundWaterFillColor: 'rgb(175,175,175)', + naturalWaterFillColor: 'rgb(175,175,175)', + OceanWaterFillColor: 'rgb(175,175,175)', + attractionStyleWaterSlideLineColor: 'rgb(175,175,175)', Review Comment: ## Duplicate property This property is duplicated [in a later property](1). [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/666) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
