github-advanced-security[bot] commented on code in PR #757:
URL:
https://github.com/apache/incubator-baremaps/pull/757#discussion_r1375469128
##########
baremaps-core/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlChangeSpliterator.java:
##########
@@ -155,8 +155,8 @@
private Node readNode() throws XMLStreamException {
long id = Long.parseLong(reader.getAttributeValue(null,
ATTRIBUTE_NAME_ID));
Info info = readInfo();
- double latitude = Double.parseDouble(reader.getAttributeValue(null,
ATTRIBUTE_NAME_LATITUDE));
- double longitude = Double.parseDouble(reader.getAttributeValue(null,
ATTRIBUTE_NAME_LONGITUDE));
+ double lat = Double.parseDouble(reader.getAttributeValue(null,
ATTRIBUTE_NAME_LATITUDE));
+ double lon = Double.parseDouble(reader.getAttributeValue(null,
ATTRIBUTE_NAME_LONGITUDE));
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/828)
##########
baremaps-core/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlChangeSpliterator.java:
##########
@@ -155,8 +155,8 @@
private Node readNode() throws XMLStreamException {
long id = Long.parseLong(reader.getAttributeValue(null,
ATTRIBUTE_NAME_ID));
Info info = readInfo();
- double latitude = Double.parseDouble(reader.getAttributeValue(null,
ATTRIBUTE_NAME_LATITUDE));
- double longitude = Double.parseDouble(reader.getAttributeValue(null,
ATTRIBUTE_NAME_LONGITUDE));
+ double lat = Double.parseDouble(reader.getAttributeValue(null,
ATTRIBUTE_NAME_LATITUDE));
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/827)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
