This is an automated email from the ASF dual-hosted git repository.

bchapuis pushed a commit to branch improve-extrusion
in repository https://gitbox.apache.org/repos/asf/incubator-baremaps.git

commit 7c480b8d5be13e64b0a94deb3faad70b0b785281
Author: Bertil Chapuis <[email protected]>
AuthorDate: Sat Dec 2 21:26:44 2023 +0100

    Improve building extrusion
---
 basemap/layers/building/extrusion.js | 5 ++++-
 basemap/layers/building/tileset.js   | 4 ++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/basemap/layers/building/extrusion.js 
b/basemap/layers/building/extrusion.js
index f5ebe305..697f28e6 100644
--- a/basemap/layers/building/extrusion.js
+++ b/basemap/layers/building/extrusion.js
@@ -21,7 +21,10 @@ export default {
     type: 'fill-extrusion',
     source: 'baremaps',
     'source-layer': 'building',
-    filter: ['!=', ['get', 'building'], 'no'],
+    filter: ['all',
+        ['!=', ['get', 'building'], 'no'],
+        ['!=', ['get', 'building:part'], 'no']
+    ],
     layout: {
         visibility: 'visible',
     },
diff --git a/basemap/layers/building/tileset.js 
b/basemap/layers/building/tileset.js
index 12c9a8b7..b57e588b 100644
--- a/basemap/layers/building/tileset.js
+++ b/basemap/layers/building/tileset.js
@@ -27,6 +27,8 @@ export default {
                     tags
                         || jsonb_build_object('extrusion:base',
                             CASE
+                                WHEN tags ? 'min_height'
+                                    THEN convert_to_number(tags ->> 
'min_height', 0)
                                 WHEN tags ? 'building:min_height'
                                     THEN convert_to_number(tags ->> 
'building:min_height', 0)
                                 WHEN tags ? 'building:min_level'
@@ -56,6 +58,8 @@ export default {
                     tags
                         || jsonb_build_object('extrusion:base',
                             CASE
+                                WHEN tags ? 'min_height'
+                                    THEN convert_to_number(tags ->> 
'min_height', 0)
                                 WHEN tags ? 'building:min_height'
                                     THEN convert_to_number(tags ->> 
'building:min_height', 0)
                                 WHEN tags ? 'building:min_level'

Reply via email to