(incubator-baremaps) branch main updated: Improve building extrusion (#809)

[bchapuis]

This is an automated email from the ASF dual-hosted git repository.

bchapuis pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-baremaps.git


The following commit(s) were added to refs/heads/main by this push:
     new 00e998ed Improve building extrusion (#809)
00e998ed is described below

commit 00e998edbbf18667f671724565afeae44783df7d
Author: Bertil Chapuis <bchap...@gmail.com>
AuthorDate: Mon Dec 4 01:32:08 2023 +0100

    Improve building extrusion (#809)
---
 basemap/layers/building/extrusion.js | 5 ++++-
 basemap/layers/building/tileset.js   | 4 ++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/basemap/layers/building/extrusion.js 
b/basemap/layers/building/extrusion.js
index f5ebe305..697f28e6 100644
--- a/basemap/layers/building/extrusion.js
+++ b/basemap/layers/building/extrusion.js
@@ -21,7 +21,10 @@ export default {
     type: 'fill-extrusion',
     source: 'baremaps',
     'source-layer': 'building',
-    filter: ['!=', ['get', 'building'], 'no'],
+    filter: ['all',
+        ['!=', ['get', 'building'], 'no'],
+        ['!=', ['get', 'building:part'], 'no']
+    ],
     layout: {
         visibility: 'visible',
     },
diff --git a/basemap/layers/building/tileset.js 
b/basemap/layers/building/tileset.js
index 12c9a8b7..b57e588b 100644
--- a/basemap/layers/building/tileset.js
+++ b/basemap/layers/building/tileset.js
@@ -27,6 +27,8 @@ export default {
                     tags
                         || jsonb_build_object('extrusion:base',
                             CASE
+                                WHEN tags ? 'min_height'
+                                    THEN convert_to_number(tags ->> 
'min_height', 0)
                                 WHEN tags ? 'building:min_height'
                                     THEN convert_to_number(tags ->> 
'building:min_height', 0)
                                 WHEN tags ? 'building:min_level'
@@ -56,6 +58,8 @@ export default {
                     tags
                         || jsonb_build_object('extrusion:base',
                             CASE
+                                WHEN tags ? 'min_height'
+                                    THEN convert_to_number(tags ->> 
'min_height', 0)
                                 WHEN tags ? 'building:min_height'
                                     THEN convert_to_number(tags ->> 
'building:min_height', 0)
                                 WHEN tags ? 'building:min_level'