github-advanced-security[bot] commented on code in PR #841:
URL:
https://github.com/apache/incubator-baremaps/pull/841#discussion_r1513610074
##########
baremaps-core/src/test/java/org/apache/baremaps/geocoder/GeonamesIndexTest.java:
##########
@@ -64,37 +64,46 @@
@Test
void testCreateIndex() throws Exception {
var geonamesQuery =
- new
GeonamesQueryBuilder().queryText("vaduz").countryCode("LI").build();
+ new
GeonamesQueryBuilder().queryText("yverdon").countryCode("CH").build();
var topDocs = searcher.search(geonamesQuery, 1);
var doc =
searcher.doc(Arrays.stream(topDocs.scoreDocs).findFirst().get().doc);
- assertEquals("Vaduz", doc.getField("name").stringValue());
+ assertEquals("Yverdon-les-bains", doc.getField("name").stringValue());
}
@Test
void testOrQuery() throws Exception {
- var geonamesQuery =
- new GeonamesQueryBuilder().queryText("vaduz
berlin").countryCode("LI").build();
- var topDocs = searcher.search(geonamesQuery, 1);
- var doc =
searcher.doc(Arrays.stream(topDocs.scoreDocs).findFirst().get().doc);
- assertEquals("Vaduz", doc.getField("name").stringValue());
+ var geonamesQuery = new GeonamesQueryBuilder()
+ .queryText("bains cheseaux")
+ .countryCode("CH")
+ .build();
+ var topDocs = searcher.search(geonamesQuery, 2);
+ assertEquals(2, topDocs.totalHits.value);
+ var doc0 = searcher.doc(topDocs.scoreDocs[0].doc);
Review Comment:
## Deprecated method or constructor invocation
Invoking [IndexSearcher.doc](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/994)
##########
baremaps-core/src/test/java/org/apache/baremaps/geocoder/GeonamesIndexTest.java:
##########
@@ -64,37 +64,46 @@
@Test
void testCreateIndex() throws Exception {
var geonamesQuery =
- new
GeonamesQueryBuilder().queryText("vaduz").countryCode("LI").build();
+ new
GeonamesQueryBuilder().queryText("yverdon").countryCode("CH").build();
var topDocs = searcher.search(geonamesQuery, 1);
var doc =
searcher.doc(Arrays.stream(topDocs.scoreDocs).findFirst().get().doc);
- assertEquals("Vaduz", doc.getField("name").stringValue());
+ assertEquals("Yverdon-les-bains", doc.getField("name").stringValue());
}
@Test
void testOrQuery() throws Exception {
- var geonamesQuery =
- new GeonamesQueryBuilder().queryText("vaduz
berlin").countryCode("LI").build();
- var topDocs = searcher.search(geonamesQuery, 1);
- var doc =
searcher.doc(Arrays.stream(topDocs.scoreDocs).findFirst().get().doc);
- assertEquals("Vaduz", doc.getField("name").stringValue());
+ var geonamesQuery = new GeonamesQueryBuilder()
+ .queryText("bains cheseaux")
+ .countryCode("CH")
+ .build();
+ var topDocs = searcher.search(geonamesQuery, 2);
+ assertEquals(2, topDocs.totalHits.value);
+ var doc0 = searcher.doc(topDocs.scoreDocs[0].doc);
+ assertEquals("Yverdon-les-bains", doc0.getField("name").stringValue());
+ var doc1 = searcher.doc(topDocs.scoreDocs[1].doc);
Review Comment:
## Deprecated method or constructor invocation
Invoking [IndexSearcher.doc](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/995)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
