github-advanced-security[bot] commented on code in PR #852:
URL:
https://github.com/apache/incubator-baremaps/pull/852#discussion_r1604054789
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/pbf/PbfEntityReader.java:
##########
@@ -102,8 +102,8 @@
* @param inputStream an osm pbf {@link InputStream}
* @return a stream of blocks
*/
- public Stream<Entity> stream(InputStream inputStream) {
- return reader.stream(inputStream).flatMap(block -> {
+ public Stream<Entity> read(InputStream inputStream) {
Review Comment:
## Missing Override annotation
This method overrides [Reader<Stream<Entity>>.read](1); it is advisable to
add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1386)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java:
##########
@@ -87,7 +87,7 @@
* @param input
* @return
*/
- public Stream<Entity> stream(InputStream input) {
+ public Stream<Entity> read(InputStream input) {
Review Comment:
## Missing Override annotation
This method overrides [Reader<Stream<Entity>>.read](1); it is advisable to
add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1388)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlChangeReader.java:
##########
@@ -22,19 +22,19 @@
import java.io.InputStream;
import java.util.stream.Stream;
import java.util.stream.StreamSupport;
-import org.apache.baremaps.openstreetmap.OsmReader;
+import org.apache.baremaps.openstreetmap.OpenStreetMap.Reader;
import org.apache.baremaps.openstreetmap.model.Change;
/** A utility class for parsing an OpenStreetMap change file. */
-public class XmlChangeReader implements OsmReader<Change> {
+public class XmlChangeReader implements Reader<Stream<Change>> {
/**
* Creates an ordered stream of OSM changes from an XML file.
*
* @param input
* @return
*/
- public Stream<Change> stream(InputStream input) {
+ public Stream<Change> read(InputStream input) {
Review Comment:
## Missing Override annotation
This method overrides [Reader<Stream<Change>>.read](1); it is advisable to
add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1387)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java:
##########
@@ -35,48 +35,48 @@
import org.locationtech.jts.geom.Coordinate;
/** A utility class for parsing an OpenStreetMap XML file. */
-public class XmlEntityReader implements OsmReader<Entity> {
+public class XmlEntityReader implements EntityReader<Stream<Entity>> {
private boolean geometry = false;
private int srid = 4326;
- private DataMap<Long, Coordinate> coordinateMap;
+ private Map<Long, Coordinate> coordinateMap;
- private DataMap<Long, List<Long>> referenceMap;
+ private Map<Long, List<Long>> referenceMap;
- public boolean geometries() {
+ public boolean getGeometries() {
return geometry;
}
- public XmlEntityReader geometries(boolean geometries) {
+ public XmlEntityReader setGeometries(boolean geometries) {
Review Comment:
## Missing Override annotation
This method overrides [EntityReader<Stream<Entity>>.setGeometries](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1395)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java:
##########
@@ -35,48 +35,48 @@
import org.locationtech.jts.geom.Coordinate;
/** A utility class for parsing an OpenStreetMap XML file. */
-public class XmlEntityReader implements OsmReader<Entity> {
+public class XmlEntityReader implements EntityReader<Stream<Entity>> {
private boolean geometry = false;
private int srid = 4326;
- private DataMap<Long, Coordinate> coordinateMap;
+ private Map<Long, Coordinate> coordinateMap;
- private DataMap<Long, List<Long>> referenceMap;
+ private Map<Long, List<Long>> referenceMap;
- public boolean geometries() {
+ public boolean getGeometries() {
Review Comment:
## Missing Override annotation
This method overrides [EntityReader<Stream<Entity>>.getGeometries](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1396)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java:
##########
@@ -35,48 +35,48 @@
import org.locationtech.jts.geom.Coordinate;
/** A utility class for parsing an OpenStreetMap XML file. */
-public class XmlEntityReader implements OsmReader<Entity> {
+public class XmlEntityReader implements EntityReader<Stream<Entity>> {
private boolean geometry = false;
private int srid = 4326;
- private DataMap<Long, Coordinate> coordinateMap;
+ private Map<Long, Coordinate> coordinateMap;
- private DataMap<Long, List<Long>> referenceMap;
+ private Map<Long, List<Long>> referenceMap;
- public boolean geometries() {
+ public boolean getGeometries() {
return geometry;
}
- public XmlEntityReader geometries(boolean geometries) {
+ public XmlEntityReader setGeometries(boolean geometries) {
this.geometry = geometries;
return this;
}
- public int projection() {
+ public int getSrid() {
return srid;
}
- public XmlEntityReader projection(int srid) {
+ public XmlEntityReader setSrid(int srid) {
this.srid = srid;
return this;
}
- public DataMap<Long, Coordinate> coordinateMap() {
+ public Map<Long, Coordinate> getCoordinateMap() {
return coordinateMap;
}
- public XmlEntityReader coordinateMap(DataMap<Long, Coordinate>
coordinateMap) {
+ public XmlEntityReader setCoordinateMap(Map<Long, Coordinate> coordinateMap)
{
this.coordinateMap = coordinateMap;
return this;
}
- public DataMap<Long, List<Long>> referenceMap() {
+ public Map<Long, List<Long>> getReferenceMap() {
Review Comment:
## Missing Override annotation
This method overrides [EntityReader<Stream<Entity>>.getReferenceMap](1); it
is advisable to add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1390)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java:
##########
@@ -35,48 +35,48 @@
import org.locationtech.jts.geom.Coordinate;
/** A utility class for parsing an OpenStreetMap XML file. */
-public class XmlEntityReader implements OsmReader<Entity> {
+public class XmlEntityReader implements EntityReader<Stream<Entity>> {
private boolean geometry = false;
private int srid = 4326;
- private DataMap<Long, Coordinate> coordinateMap;
+ private Map<Long, Coordinate> coordinateMap;
- private DataMap<Long, List<Long>> referenceMap;
+ private Map<Long, List<Long>> referenceMap;
- public boolean geometries() {
+ public boolean getGeometries() {
return geometry;
}
- public XmlEntityReader geometries(boolean geometries) {
+ public XmlEntityReader setGeometries(boolean geometries) {
this.geometry = geometries;
return this;
}
- public int projection() {
+ public int getSrid() {
return srid;
}
- public XmlEntityReader projection(int srid) {
+ public XmlEntityReader setSrid(int srid) {
Review Comment:
## Missing Override annotation
This method overrides [EntityReader<Stream<Entity>>.setSrid](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1393)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java:
##########
@@ -35,48 +35,48 @@
import org.locationtech.jts.geom.Coordinate;
/** A utility class for parsing an OpenStreetMap XML file. */
-public class XmlEntityReader implements OsmReader<Entity> {
+public class XmlEntityReader implements EntityReader<Stream<Entity>> {
private boolean geometry = false;
private int srid = 4326;
- private DataMap<Long, Coordinate> coordinateMap;
+ private Map<Long, Coordinate> coordinateMap;
- private DataMap<Long, List<Long>> referenceMap;
+ private Map<Long, List<Long>> referenceMap;
- public boolean geometries() {
+ public boolean getGeometries() {
return geometry;
}
- public XmlEntityReader geometries(boolean geometries) {
+ public XmlEntityReader setGeometries(boolean geometries) {
this.geometry = geometries;
return this;
}
- public int projection() {
+ public int getSrid() {
return srid;
}
- public XmlEntityReader projection(int srid) {
+ public XmlEntityReader setSrid(int srid) {
this.srid = srid;
return this;
}
- public DataMap<Long, Coordinate> coordinateMap() {
+ public Map<Long, Coordinate> getCoordinateMap() {
return coordinateMap;
}
- public XmlEntityReader coordinateMap(DataMap<Long, Coordinate>
coordinateMap) {
+ public XmlEntityReader setCoordinateMap(Map<Long, Coordinate> coordinateMap)
{
Review Comment:
## Missing Override annotation
This method overrides [EntityReader<Stream<Entity>>.setCoordinateMap](1); it
is advisable to add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1391)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java:
##########
@@ -35,48 +35,48 @@
import org.locationtech.jts.geom.Coordinate;
/** A utility class for parsing an OpenStreetMap XML file. */
-public class XmlEntityReader implements OsmReader<Entity> {
+public class XmlEntityReader implements EntityReader<Stream<Entity>> {
private boolean geometry = false;
private int srid = 4326;
- private DataMap<Long, Coordinate> coordinateMap;
+ private Map<Long, Coordinate> coordinateMap;
- private DataMap<Long, List<Long>> referenceMap;
+ private Map<Long, List<Long>> referenceMap;
- public boolean geometries() {
+ public boolean getGeometries() {
return geometry;
}
- public XmlEntityReader geometries(boolean geometries) {
+ public XmlEntityReader setGeometries(boolean geometries) {
this.geometry = geometries;
return this;
}
- public int projection() {
+ public int getSrid() {
return srid;
}
- public XmlEntityReader projection(int srid) {
+ public XmlEntityReader setSrid(int srid) {
this.srid = srid;
return this;
}
- public DataMap<Long, Coordinate> coordinateMap() {
+ public Map<Long, Coordinate> getCoordinateMap() {
return coordinateMap;
}
- public XmlEntityReader coordinateMap(DataMap<Long, Coordinate>
coordinateMap) {
+ public XmlEntityReader setCoordinateMap(Map<Long, Coordinate> coordinateMap)
{
this.coordinateMap = coordinateMap;
return this;
}
- public DataMap<Long, List<Long>> referenceMap() {
+ public Map<Long, List<Long>> getReferenceMap() {
return referenceMap;
}
- public XmlEntityReader referenceMap(DataMap<Long, List<Long>> referenceMap) {
+ public XmlEntityReader setReferenceMap(Map<Long, List<Long>> referenceMap) {
Review Comment:
## Missing Override annotation
This method overrides [EntityReader<Stream<Entity>>.setReferenceMap](1); it
is advisable to add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1389)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java:
##########
@@ -35,48 +35,48 @@
import org.locationtech.jts.geom.Coordinate;
/** A utility class for parsing an OpenStreetMap XML file. */
-public class XmlEntityReader implements OsmReader<Entity> {
+public class XmlEntityReader implements EntityReader<Stream<Entity>> {
private boolean geometry = false;
private int srid = 4326;
- private DataMap<Long, Coordinate> coordinateMap;
+ private Map<Long, Coordinate> coordinateMap;
- private DataMap<Long, List<Long>> referenceMap;
+ private Map<Long, List<Long>> referenceMap;
- public boolean geometries() {
+ public boolean getGeometries() {
return geometry;
}
- public XmlEntityReader geometries(boolean geometries) {
+ public XmlEntityReader setGeometries(boolean geometries) {
this.geometry = geometries;
return this;
}
- public int projection() {
+ public int getSrid() {
return srid;
}
- public XmlEntityReader projection(int srid) {
+ public XmlEntityReader setSrid(int srid) {
this.srid = srid;
return this;
}
- public DataMap<Long, Coordinate> coordinateMap() {
+ public Map<Long, Coordinate> getCoordinateMap() {
Review Comment:
## Missing Override annotation
This method overrides [EntityReader<Stream<Entity>>.getCoordinateMap](1); it
is advisable to add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1392)
##########
baremaps-openstreetmap/src/main/java/org/apache/baremaps/openstreetmap/xml/XmlEntityReader.java:
##########
@@ -35,48 +35,48 @@
import org.locationtech.jts.geom.Coordinate;
/** A utility class for parsing an OpenStreetMap XML file. */
-public class XmlEntityReader implements OsmReader<Entity> {
+public class XmlEntityReader implements EntityReader<Stream<Entity>> {
private boolean geometry = false;
private int srid = 4326;
- private DataMap<Long, Coordinate> coordinateMap;
+ private Map<Long, Coordinate> coordinateMap;
- private DataMap<Long, List<Long>> referenceMap;
+ private Map<Long, List<Long>> referenceMap;
- public boolean geometries() {
+ public boolean getGeometries() {
return geometry;
}
- public XmlEntityReader geometries(boolean geometries) {
+ public XmlEntityReader setGeometries(boolean geometries) {
this.geometry = geometries;
return this;
}
- public int projection() {
+ public int getSrid() {
Review Comment:
## Missing Override annotation
This method overrides [EntityReader<Stream<Entity>>.getSrid](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1394)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
