Drabble commented on code in PR #855: URL: https://github.com/apache/incubator-baremaps/pull/855#discussion_r1608989495
########## baremaps-geoparquet/pom.xml: ########## @@ -0,0 +1,46 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.baremaps</groupId> + <artifactId>baremaps</artifactId> + <version>0.7.4-SNAPSHOT</version> + </parent> + <artifactId>baremaps-geoparquet</artifactId> + <dependencies> + <dependency> + <groupId>org.apache.baremaps</groupId> + <artifactId>baremaps-testing</artifactId> + </dependency> + <dependency> + <groupId>org.apache.hadoop</groupId> + <artifactId>hadoop-aws</artifactId> Review Comment: Do we need this dependency on Hadoop aws? ########## pom.xml: ########## @@ -95,13 +96,15 @@ limitations under the License. <version.lib.geopackage>6.6.4</version.lib.geopackage> <version.lib.graalvm>23.0.3</version.lib.graalvm> <version.lib.guava>33.0.0-jre</version.lib.guava> + <version.lib.hadoop>3.4.0</version.lib.hadoop> <version.lib.hikari>5.1.0</version.lib.hikari> <version.lib.ipresource>1.52</version.lib.ipresource> <version.lib.jackson>2.16.1</version.lib.jackson> <version.lib.jts>1.19.0</version.lib.jts> <version.lib.junit>5.10.2</version.lib.junit> <version.lib.log4j>3.0.0-beta2</version.lib.log4j> <version.lib.lucene>9.10.0</version.lib.lucene> + <version.lib.parquet>1.13.1</version.lib.parquet> Review Comment: Version 1.14.0 was release on Maven central I believe. Do you think we should already use it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
