github-advanced-security[bot] commented on code in PR #862:
URL:
https://github.com/apache/incubator-baremaps/pull/862#discussion_r1625062741
##########
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java:
##########
@@ -95,13 +97,27 @@
try {
if (files == null) {
files = new HashMap<>();
- Path globPath = new Path(uri.getPath());
- URI rootUri = getRootUri(uri);
- FileSystem fileSystem = FileSystem.get(rootUri, configuration);
-
- // Iterate over all the files in the path
- for (FileStatus file : fileSystem.globStatus(globPath)) {
- files.put(file, buildFileInfo(file));
+ FileSystem fs = FileSystem.get(uri, configuration);
+ FileStatus[] fileStatuses = fs.globStatus(new Path(uri));
+
+ for (FileStatus fileStatus : fileStatuses) {
+ Path filePath = fileStatus.getPath();
+ ParquetFileReader reader = ParquetFileReader.open(configuration,
filePath);
Review Comment:
## Deprecated method or constructor invocation
Invoking [ParquetFileReader.open](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1439)
##########
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/data/GeoParquetGroupImpl.java:
##########
@@ -278,7 +278,7 @@
}
}
- private List<Primitive> getValues(int fieldIndex) {
+ public List<Primitive> getValues(int fieldIndex) {
Review Comment:
## Missing Override annotation
This method overrides [GeoParquetGroup.getValues](1); it is advisable to add
an Override annotation.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1440)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
