github-advanced-security[bot] commented on code in PR #867:
URL:
https://github.com/apache/incubator-baremaps/pull/867#discussion_r1634716794
##########
baremaps-core/src/main/java/org/apache/baremaps/storage/shapefile/internal/DbaseByteReader.java:
##########
@@ -126,21 +126,21 @@
// TODO: move somewhere else
Object object = switch (fieldDescriptor.getType()) {
- case Character -> value;
- case Number -> getNumber(fieldDescriptor, value);
- case Currency -> Double.parseDouble(value.trim());
- case Integer -> Integer.parseInt(value.trim());
- case Double -> Double.parseDouble(value.trim());
- case AutoIncrement -> Integer.parseInt(value.trim());
- case Logical -> value;
- case Date -> value;
- case Memo -> value;
- case FloatingPoint -> value;
- case Picture -> value;
- case VariField -> value;
- case Variant -> value;
- case TimeStamp -> value;
- case DateTime -> value;
+ case CHARACTER -> value;
+ case NUMBER -> getNumber(fieldDescriptor, value);
+ case CURRENCY -> Double.parseDouble(value.trim());
+ case INTEGER -> Integer.parseInt(value.trim());
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1442)
##########
baremaps-core/src/main/java/org/apache/baremaps/storage/shapefile/internal/DbaseByteReader.java:
##########
@@ -126,21 +126,21 @@
// TODO: move somewhere else
Object object = switch (fieldDescriptor.getType()) {
- case Character -> value;
- case Number -> getNumber(fieldDescriptor, value);
- case Currency -> Double.parseDouble(value.trim());
- case Integer -> Integer.parseInt(value.trim());
- case Double -> Double.parseDouble(value.trim());
- case AutoIncrement -> Integer.parseInt(value.trim());
- case Logical -> value;
- case Date -> value;
- case Memo -> value;
- case FloatingPoint -> value;
- case Picture -> value;
- case VariField -> value;
- case Variant -> value;
- case TimeStamp -> value;
- case DateTime -> value;
+ case CHARACTER -> value;
+ case NUMBER -> getNumber(fieldDescriptor, value);
+ case CURRENCY -> Double.parseDouble(value.trim());
+ case INTEGER -> Integer.parseInt(value.trim());
+ case DOUBLE -> Double.parseDouble(value.trim());
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1443)
##########
baremaps-core/src/main/java/org/apache/baremaps/storage/shapefile/internal/DbaseByteReader.java:
##########
@@ -126,21 +126,21 @@
// TODO: move somewhere else
Object object = switch (fieldDescriptor.getType()) {
- case Character -> value;
- case Number -> getNumber(fieldDescriptor, value);
- case Currency -> Double.parseDouble(value.trim());
- case Integer -> Integer.parseInt(value.trim());
- case Double -> Double.parseDouble(value.trim());
- case AutoIncrement -> Integer.parseInt(value.trim());
- case Logical -> value;
- case Date -> value;
- case Memo -> value;
- case FloatingPoint -> value;
- case Picture -> value;
- case VariField -> value;
- case Variant -> value;
- case TimeStamp -> value;
- case DateTime -> value;
+ case CHARACTER -> value;
+ case NUMBER -> getNumber(fieldDescriptor, value);
+ case CURRENCY -> Double.parseDouble(value.trim());
+ case INTEGER -> Integer.parseInt(value.trim());
+ case DOUBLE -> Double.parseDouble(value.trim());
+ case AUTO_INCREMENT -> Integer.parseInt(value.trim());
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1444)
##########
baremaps-core/src/main/java/org/apache/baremaps/storage/shapefile/internal/DbaseByteReader.java:
##########
@@ -126,21 +126,21 @@
// TODO: move somewhere else
Object object = switch (fieldDescriptor.getType()) {
- case Character -> value;
- case Number -> getNumber(fieldDescriptor, value);
- case Currency -> Double.parseDouble(value.trim());
- case Integer -> Integer.parseInt(value.trim());
- case Double -> Double.parseDouble(value.trim());
- case AutoIncrement -> Integer.parseInt(value.trim());
- case Logical -> value;
- case Date -> value;
- case Memo -> value;
- case FloatingPoint -> value;
- case Picture -> value;
- case VariField -> value;
- case Variant -> value;
- case TimeStamp -> value;
- case DateTime -> value;
+ case CHARACTER -> value;
+ case NUMBER -> getNumber(fieldDescriptor, value);
+ case CURRENCY -> Double.parseDouble(value.trim());
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/incubator-baremaps/security/code-scanning/1441)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
