This is an automated email from the ASF dual-hosted git repository. bchapuis pushed a commit to branch sonar in repository https://gitbox.apache.org/repos/asf/incubator-baremaps.git
commit 7393520a1b6c280c281dfed0264f3cab45761a32 Author: Bertil Chapuis <[email protected]> AuthorDate: Wed Jun 12 23:36:28 2024 +0200 Fix sonar issues --- .../database/postgres/HeaderRepository.java | 25 +++++++++++----------- .../shapefile/internal/ShapefileByteReader.java | 1 + 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/baremaps-core/src/main/java/org/apache/baremaps/database/postgres/HeaderRepository.java b/baremaps-core/src/main/java/org/apache/baremaps/database/postgres/HeaderRepository.java index b9040b4f..7ff27821 100644 --- a/baremaps-core/src/main/java/org/apache/baremaps/database/postgres/HeaderRepository.java +++ b/baremaps-core/src/main/java/org/apache/baremaps/database/postgres/HeaderRepository.java @@ -65,14 +65,14 @@ public class HeaderRepository implements Repository<Long, Header> { */ public HeaderRepository(DataSource dataSource) { this( - dataSource, - "public", - "osm_headers", - "replication_sequence_number", + dataSource, + "public", + "osm_headers", + "replication_sequence_number", "replication_timestamp", "replication_url", - "source", - "writing_program"); + "source", + "writing_program"); } /** @@ -87,15 +87,16 @@ public class HeaderRepository implements Repository<Long, Header> { * @param sourceColumn * @param writingProgramColumn */ + @SuppressWarnings("squid:S107") public HeaderRepository( - DataSource dataSource, - String schema, - String table, + DataSource dataSource, + String schema, + String table, String replicationSequenceNumberColumn, - String replicationTimestampColumn, + String replicationTimestampColumn, String replicationUrlColumn, - String sourceColumn, - String writingProgramColumn) { + String sourceColumn, + String writingProgramColumn) { var fullTableName = String.format("%1$s.%2$s", schema, table); this.dataSource = dataSource; this.createTable = String.format(""" diff --git a/baremaps-core/src/main/java/org/apache/baremaps/storage/shapefile/internal/ShapefileByteReader.java b/baremaps-core/src/main/java/org/apache/baremaps/storage/shapefile/internal/ShapefileByteReader.java index 86cc3ccd..aac85dcf 100644 --- a/baremaps-core/src/main/java/org/apache/baremaps/storage/shapefile/internal/ShapefileByteReader.java +++ b/baremaps-core/src/main/java/org/apache/baremaps/storage/shapefile/internal/ShapefileByteReader.java @@ -214,6 +214,7 @@ public class ShapefileByteReader extends CommonByteReader { try { databaseReader.close(); } catch (IOException e) { + // Ignore } } }
