bchapuis commented on PR #880: URL: https://github.com/apache/incubator-baremaps/pull/880#issuecomment-2172604292
@yagagagaga Thanks a lot, this is a good contribution. This part of the codebase really deserves more checks and tests. Regarding the HashMap, this is what I used initially. However, when dealing with very large datasets (several billion records), the cost of computing the hash code when accessing the HashMap is noticeable compared to the direct memory access of an array. The size of the array can easily be mitigated by increasing the size of segments. Unfortunately, I had to remove the JMH benchmarks due to license compatibility requirements (JMH is released under the GPL). I would keep the array for now and reintroduce some sort of benchmarks if we need to use another data structure To format the code, you need to execute `./mvnw spotless:apply`. Let me know if you need further assistance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
