github-advanced-security[bot] commented on code in PR #884: URL: https://github.com/apache/incubator-baremaps/pull/884#discussion_r1735916628
########## baremaps-core/src/main/java/org/apache/baremaps/tilestore/raster/GeoTiffReader.java: ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.baremaps.tilestore.raster; + +import java.nio.file.Path; +import org.apache.baremaps.tilestore.TileCoord; +import org.apache.baremaps.tilestore.TileStoreException; +import org.apache.sis.coverage.grid.*; +import org.apache.sis.geometry.Envelopes; +import org.apache.sis.geometry.GeneralEnvelope; +import org.apache.sis.image.ImageProcessor; +import org.apache.sis.referencing.CRS; +import org.apache.sis.referencing.CommonCRS; +import org.apache.sis.storage.*; +import org.opengis.referencing.crs.CoordinateReferenceSystem; +import org.opengis.util.FactoryException; + +public class GeoTiffReader implements AutoCloseable { + + private static final CoordinateReferenceSystem WEB_MERCATOR; + + static { + try { + WEB_MERCATOR = CRS.fromWKT(""" + ProjectedCRS["WGS 84 / Pseudo-Mercator", + BaseGeodCRS["WGS 84", + Datum["World Geodetic System 1984", + Ellipsoid["WGS 84", 6378137.0, 298.257223563]], + Unit["degree", 0.017453292519943295]], + Conversion["Popular Visualisation Pseudo-Mercator", + Method["Popular Visualisation Pseudo Mercator"]], + CS[Cartesian, 2], + Axis["Easting (X)", east], + Axis["Northing (Y)", north], + Unit["metre", 1], + Scope["Certain Web mapping and visualisation applications."], + Id["EPSG", 3857]] + """); + } catch (FactoryException e) { + throw new RuntimeException(e); + } + } + + private final DataStore dataStore; + + private final GridCoverage gridCoverage; + + public GeoTiffReader(Path path) { + try { + this.dataStore = DataStores.open(path); + var allImages = ((Aggregate) dataStore).components(); + var firstImage = (GridCoverageResource) allImages.iterator().next(); + firstImage.setLoadingStrategy(RasterLoadingStrategy.AT_GET_TILE_TIME); + gridCoverage = firstImage.read(null); + } catch (DataStoreException e) { + throw new RuntimeException(e); + } + } + + public double[] read(TileCoord tileCoord, int size, int buffer) throws TileStoreException { + try { + // Compute the buffer size and expand the envelope + var fullSize = size + 2 * buffer; + var tileEnvelope = tileCoord.envelope(); + var tileWidth = tileEnvelope.getWidth(); + var tileHeight = tileEnvelope.getHeight(); + var pixelWidth = tileWidth / size; + var pixelHeight = tileHeight / size; + tileEnvelope.expandBy(pixelWidth * buffer, pixelHeight * buffer); + + // Create the target grid geometry in the web mercator projection + var sourceEnvelope = new GeneralEnvelope(CommonCRS.WGS84.normalizedGeographic()); + sourceEnvelope.setRange(0, tileEnvelope.getMinX(), tileEnvelope.getMaxX()); + sourceEnvelope.setRange(1, tileEnvelope.getMinY(), tileEnvelope.getMaxY()); + var targetEnvelope = Envelopes.transform(sourceEnvelope, WEB_MERCATOR); + var targetSize = new GridExtent(fullSize, fullSize); + var targetGridGeometry = + new GridGeometry(targetSize, targetEnvelope, GridOrientation.DISPLAY); + + // Resample and render the image + var gridCoverageProcessor = new GridCoverageProcessor(); + gridCoverageProcessor.setInterpolation(new BicubicInterpolation()); + var gridCoverage = gridCoverageProcessor.resample(this.gridCoverage, targetGridGeometry); Review Comment: ## Possible confusion of local and field Potentially confusing name: method [read](1) also refers to field [gridCoverage](2) (as this.gridCoverage). [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/1549) ########## baremaps-core/src/main/java/org/apache/baremaps/tilestore/raster/BicubicInterpolation.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.baremaps.tilestore.raster; + +import java.awt.*; +import java.nio.DoubleBuffer; +import org.apache.sis.image.Interpolation; + +class BicubicInterpolation extends Interpolation { + + public Dimension getSupportSize() { Review Comment: ## Missing Override annotation This method overrides [Interpolation.getSupportSize](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/1548) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
