bchapuis commented on code in PR #916:
URL:
https://github.com/apache/incubator-baremaps/pull/916#discussion_r1913439704
##########
pom.xml:
##########
@@ -719,8 +719,11 @@ limitations under the License.
<archive>
<manifestEntries>
<Build-Date>${project.build.outputTimestamp}</Build-Date>
- <Build-Version>${project.version}</Build-Version>
- <Build-Jdk>${java.version}</Build-Jdk>
+ <Build-Version>${project.version}</Build-Version>
+ <Build-Jdk>${java.version}</Build-Jdk>
+ <Specification-Title>Apache Baremaps CSV
(incubating)</Specification-Title>
Review Comment:
@rohitYaduvanshi Thanks for this PR. I guess we should probably add a
`<name>` tag in all sub modules (e.g baremaps-csv/pom.xml) and use it to
generate the Specification-Title dynamically. From what I understand, with the
current solution, all the generated jars will have the same specification title.
```xml
<name>baremaps-csv</name>
...
<Specification-Title>${project.name}</Specification-Title>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
