bchapuis commented on PR #958: URL: https://github.com/apache/incubator-baremaps/pull/958#issuecomment-2810641599
Thanks a lot for taking the time to contribute. I usually wait to use parameterized tests until there are a lot of test cases and the repeated code starts to get messy. When there are only a few checks, I think regular test lines are easier to read and understand. Parameterized tests can make things harder to follow if they don't really help with keeping the code cleaner or easier to update. In this case, we're just checking the content of a single record at a few positions, so parametrized tests may be an overkill. Here is another example of where we used a provider for parametried test in baremaps: https://github.com/apache/incubator-baremaps/blob/main/baremaps-data/src/test/java/org/apache/baremaps/data/type/DataTypeProvider.java If you are interested in contributing to apache baremaps, please do not hesitate to share your usecase on the mailing list or to start with one of the "good first issues". We will be happy to help. https://github.com/apache/incubator-baremaps/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
