[
https://issues.apache.org/jira/browse/BEAM-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786286#comment-15786286
]
ASF GitHub Bot commented on BEAM-1231:
--------------------------------------
GitHub user lukecwik opened a pull request:
https://github.com/apache/beam/pull/1717
[BEAM-1231] Use well known coder types in Java
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam java_well_known_coders
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1717.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1717
----
commit 71d2a6eb3f9b654becfaa43d6b218f36f6928708
Author: Luke Cwik <[email protected]>
Date: 2016-12-29T20:03:31Z
[BEAM-1231] Use well known coder types in Java
commit 5b614dece8babcad5b9a087e969d143212be0a3d
Author: Luke Cwik <[email protected]>
Date: 2016-12-29T21:39:45Z
Swap to use initializeCloudObject as customization point for CloudObjects.
Hide StandardCoder#getComponents() and have coders only rely on
Coder#getCoderArguments()
commit ad061a7c4e696d6407d6d209ff7e35933c9fc71b
Author: Luke Cwik <[email protected]>
Date: 2016-12-29T22:20:04Z
Use kind:* for certain well known coder types.
commit b927e68afbaa35f8dac939e39b93b8dc9c224e66
Author: Luke Cwik <[email protected]>
Date: 2016-12-29T22:31:19Z
fixup! Minor formatting/comment changes
----
> Use well known coder types in Java for WindowedValue, GlobalWindow, and
> LengthPrefix
> ------------------------------------------------------------------------------------
>
> Key: BEAM-1231
> URL: https://issues.apache.org/jira/browse/BEAM-1231
> Project: Beam
> Issue Type: Bug
> Components: beam-model-fn-api
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
>
> Add support for using kind for well known coder types in Apache Beam for Java
> The following specific cloud object representations for the following types
> should exist:
> kind:pair (TupleCoder with two components)
> kind:stream (IterableCoder with a single component)
> kind:global_window (GlobalWindowCoder)
> kind:length_prefix (A new type of coder which always encodes the length of
> the value type as a prefix, has a single component)
> kind:windowed_value (A wrapper coder with two components (value coder and
> window coder))
> These changes are towards having a common binary representation for certain
> well known coders across multiple languages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
