[
https://issues.apache.org/jira/browse/BEAM-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798908#comment-15798908
]
ASF GitHub Bot commented on BEAM-1228:
--------------------------------------
GitHub user eljefe6a opened a pull request:
https://github.com/apache/beam/pull/1732
BEAM-1228 Improve Regex
Improve Regex class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eljefe6a/incubator-beam RegexImprovements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1732.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1732
----
commit c9cf6b2e88e54213b6f69245064292e169cae8d2
Author: Jesse Anderson <[email protected]>
Date: 2016-12-28T23:10:34Z
Added named regex groups, return all groups, and marked Pattern as final.
commit 65fc72c1d9a7857f397bc89148b6dcd4289a954b
Author: Jesse Anderson <[email protected]>
Date: 2016-12-29T01:38:22Z
Everything wasn’t final.
commit ce34e980925113a747aef199c3dc0e2cec72b789
Author: Jesse Anderson <[email protected]>
Date: 2017-01-04T00:05:29Z
Added Pattern as a parameter to every method. Made every string method call
with a Pattern.
----
> Improve Regex
> -------------
>
> Key: BEAM-1228
> URL: https://issues.apache.org/jira/browse/BEAM-1228
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Affects Versions: 0.3.0-incubating
> Reporter: Jesse Anderson
> Assignee: Jesse Anderson
>
> The Regex class needs some extra work:
> * Named regex groups where applicable
> * Return all groups where applicable
> * Mark Pattern as final.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
