[
https://issues.apache.org/jira/browse/BEAM-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819138#comment-15819138
]
ASF GitHub Bot commented on BEAM-1260:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/1767
[BEAM-1260] Revert "Captures assertion site and message in PAssert"
This reverts commit c62611c73ab0f9a5769f3ee9b28b11e917628f78.
It breaks post-commit Dataflow and Flink runners, e.g.
https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2010/org.apache.beam$beam-runners-google-cloud-dataflow-java/consoleFull
R: @kennknowles
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam revert-passert-site
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1767.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1767
----
commit 47592f66222e0b8a82d4c94d14cfba38044658f4
Author: Eugene Kirpichov <[email protected]>
Date: 2017-01-11T20:55:09Z
Revert "Captures assertion site and message in PAssert"
This reverts commit c62611c73ab0f9a5769f3ee9b28b11e917628f78.
It breaks post-commit Dataflow and Flink runners.
----
> PAssert should capture the assertion site
> -----------------------------------------
>
> Key: BEAM-1260
> URL: https://issues.apache.org/jira/browse/BEAM-1260
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
> Fix For: 0.5.0
>
>
> When a PAssert assertion fails, it doesn't tell where the assertion
> (PAssert.that(blah)) call was made in code - only when the failure was
> detected, i.e. somewhere deep in worker code usually.
> It also doesn't allow specifying a message (unlike JUnit).
> This issue is about improving the way PAssert failures are reported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
