[
https://issues.apache.org/jira/browse/BEAM-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832726#comment-15832726
]
ASF GitHub Bot commented on BEAM-1100:
--------------------------------------
GitHub user aaltay opened a pull request:
https://github.com/apache/beam/pull/1807
[BEAM-1100] Skip pylint when running outside of a git repository.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aaltay/incubator-beam pyl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1807.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1807
----
commit f2d0b2bb0c3f79f9a24d2c22a41976cd99b85e8f
Author: Ahmet Altay <[email protected]>
Date: 2017-01-21T01:32:29Z
Skip pylint when running outside of a git repository.
----
> Consider removing pylint from mvn verify
> ----------------------------------------
>
> Key: BEAM-1100
> URL: https://issues.apache.org/jira/browse/BEAM-1100
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Ahmet Altay
> Assignee: Ahmet Altay
> Priority: Critical
>
> pylint depends on git commands for getting a list of changed files to run the
> linter on. This does not make sense in some cases (for example when in the
> case code was copied/packaged out of git structure). A few possible remedies
> could be considered:
> - Remove pylint step from mvn verify
> - Add an option to pylint run on whole code base and use this in mvn verify
> - Change pylint to run on the whole code base (instead of just changed files)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
