[
https://issues.apache.org/jira/browse/BEAM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837338#comment-15837338
]
ASF GitHub Bot commented on BEAM-886:
-------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/1842
[BEAM-886] Migrate CallableWrapperDoFn to extend NewDoFn
- Migrate the CallableWrapperDoFn class to extend NewDoFn instead of OldDoFn
- Add a test for callables such as set/list as they can not be used with
inspect module
- Make sure all unittests pass
- Performance tested the old vs new dofn and didn't find any changes in
performance
Future work:
- Migrate the OldDoFn to New
- Remove OldDoFn from the code
- Rename NewDoFn to DoFn
- Deprecate use of context
R: @robertwb
CC: @aaltay
---
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/incubator-beam
BEAM-886-Add-NewDoFn-class-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1842
----
commit 38e4e8713263ba987ce374c94f59534904bcb9f3
Author: Sourabh Bajaj <[email protected]>
Date: 2017-01-25T07:19:40Z
Migrate CallableWrapperDoFn to use the NewDoFn type
----
> Support new DoFn in Python SDK
> ------------------------------
>
> Key: BEAM-886
> URL: https://issues.apache.org/jira/browse/BEAM-886
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Ahmet Altay
> Assignee: Sourabh Bajaj
> Labels: backward-incompatible, sdk-consistency
>
> Figure out what is needed for supporting new DoFns, add support and removed
> old DoFns.
> Related Docs from Java:
> Original Proposal email:
> https://lists.apache.org/thread.html/2abf32d528dbb64b79853552c5d10c217e2194f0685af21aeb4635dd@%3Cdev.beam.apache.org%3E
> Presentation & Doc (with short Python sections):
> https://s.apache.org/presenting-a-new-dofn
> https://s.apache.org/a-new-dofn
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
