Repository: beam Updated Branches: refs/heads/master c52578370 -> 95beda69b
[BEAM-246] re-enable Checkstyle by default This adds 50%+ overhead to a clean build (with testing disabled), but per dev@ discussion is a huge usability win for contributors and committers alike. https://lists.apache.org/thread.html/CAA8k_FKafuon8GEA3CXwR2MZh2kAXEFZQK=bgx5tk2fzjeb...@mail.gmail.com Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/f05c5d32 Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/f05c5d32 Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/f05c5d32 Branch: refs/heads/master Commit: f05c5d32cb5dbee6de4247a803d7b7c7fbe52173 Parents: c525783 Author: Dan Halperin <dhalp...@google.com> Authored: Tue Jan 24 13:52:06 2017 -0800 Committer: Dan Halperin <dhalp...@google.com> Committed: Wed Jan 25 12:13:33 2017 -0800 ---------------------------------------------------------------------- examples/pom.xml | 14 +++++++++----- runners/pom.xml | 14 +++++++++----- sdks/pom.xml | 13 +++++++------ 3 files changed, 25 insertions(+), 16 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/f05c5d32/examples/pom.xml ---------------------------------------------------------------------- diff --git a/examples/pom.xml b/examples/pom.xml index adfbaa9..4294c2d 100644 --- a/examples/pom.xml +++ b/examples/pom.xml @@ -51,11 +51,6 @@ <build> <plugins> <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - </plugin> - - <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>findbugs-maven-plugin</artifactId> </plugin> @@ -64,4 +59,13 @@ </profile> </profiles> + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + </plugins> + </build> + </project> http://git-wip-us.apache.org/repos/asf/beam/blob/f05c5d32/runners/pom.xml ---------------------------------------------------------------------- diff --git a/runners/pom.xml b/runners/pom.xml index fb84164..ceaedfe 100644 --- a/runners/pom.xml +++ b/runners/pom.xml @@ -47,11 +47,6 @@ <build> <plugins> <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - </plugin> - - <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>findbugs-maven-plugin</artifactId> </plugin> @@ -99,4 +94,13 @@ </build> </profile> </profiles> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + </plugins> + </build> </project> http://git-wip-us.apache.org/repos/asf/beam/blob/f05c5d32/sdks/pom.xml ---------------------------------------------------------------------- diff --git a/sdks/pom.xml b/sdks/pom.xml index bfdfcd9..2682728 100644 --- a/sdks/pom.xml +++ b/sdks/pom.xml @@ -42,11 +42,6 @@ <build> <plugins> <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - </plugin> - - <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>findbugs-maven-plugin</artifactId> </plugin> @@ -58,7 +53,6 @@ <build> <pluginManagement> <plugins> - <!-- SDKs will generally offer test suites for runners, as sdks/java does. --> <plugin> <groupId>org.apache.maven.plugins</groupId> @@ -74,6 +68,13 @@ </plugin> </plugins> </pluginManagement> + + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + </plugins> </build> </project>