[
https://issues.apache.org/jira/browse/BEAM-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850212#comment-15850212
]
ASF GitHub Bot commented on BEAM-1370:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/1907
[BEAM-1370] Invoke onMerge in AfterWatermarkEarly
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This ensures that any triggering state manipulations appropriately
notify the early subtrigger before resetting the finished bit. This
ensures that any timers or state is appropriately migrated to the
merged window.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam fix_AfterWatermark_merging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1907.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1907
----
commit 80e63373e35f851fe4b909da9465d58d17ebd106
Author: Thomas Groh <[email protected]>
Date: 2017-02-02T17:23:45Z
Invoke onMerge in AfterWatermarkEarly
This ensures that any triggering state manipulations appropriately
notify the early subtrigger before resetting the finished bit. This
ensures that any timers or state is appropriately migrated to the
merged window.
----
> AfterWatermarkEarlyAndLate does not invoke the onMerge of the early trigger
> ---------------------------------------------------------------------------
>
> Key: BEAM-1370
> URL: https://issues.apache.org/jira/browse/BEAM-1370
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
>
> When a window merges in AfterWatermarkStateMachine, if the early trigger is
> not finished the state machine should invoke its onMerge. This ensures, for
> example, that with merging windows with a processing time early trigger, that
> trigger is propagated to the merged windows.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
