[
https://issues.apache.org/jira/browse/BEAM-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853621#comment-15853621
]
Daniel Halperin commented on BEAM-1223:
---------------------------------------
Hey [~staslev],
I just found in testing the 0.5.0 that this JIRA ended up also reducing
visibility for {{Sum.SumIntegersFn}} and friends. This is a breaking change,
which we are trying to keep track of for ourselves and for our users, using the
{{backward-incompatible}} label -- I added it.
I hope you don't mind: I also reworded the JIRA in order to show a more obvious
message in the Release Notes.
Thanks!
Dan
> Replace public constructors with static factory methods for Sum.[*]Fn classes
> -----------------------------------------------------------------------------
>
> Key: BEAM-1223
> URL: https://issues.apache.org/jira/browse/BEAM-1223
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Stas Levin
> Assignee: Stas Levin
> Priority: Minor
> Labels: backward-incompatible
> Fix For: 0.5.0
>
>
> {{Sum.SumDoubleFn}}, {{SumIntegerFn}} and {{SumLongFn}} are not using the
> {{X.of()}} or {{X.from()}} or other instance creation via static method
> patterns that are ubiquitous in Beam.
> Following a discussion on the dev list, it would be great to preserve a
> consistent look and feel and change the creation patterns for these classes
> to something like {{SumFn.ofLong()}} etc.
> See also the corresponding [dev list
> thread|https://lists.apache.org/thread.html/5d8e905ee49b116d13811c2a96da65eeb44ab7c002870f50936ee1ad@%3Cdev.beam.apache.org%3E].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
