[ https://issues.apache.org/jira/browse/BEAM-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854346#comment-15854346 ]
ASF GitHub Bot commented on BEAM-1395: -------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/beam/pull/1924 > SparkGroupAlsoByWindowFn not sorting grouped elements by timestamp > ------------------------------------------------------------------ > > Key: BEAM-1395 > URL: https://issues.apache.org/jira/browse/BEAM-1395 > Project: Beam > Issue Type: Bug > Components: runner-spark > Reporter: Amit Sela > Assignee: Amit Sela > > SparkGroupAlsoByWindowFn relies on the grouped elements (pre key) to be > sorted by their timestamp, which is not the case, and so could cause: > {code} > IllegalStateException: Cannot move input watermark time backwards > {code} > We should sort the values first, just like with {{Combine}} implementations: > https://github.com/apache/beam/blob/master/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkKeyedCombineFn.java#L73 -- This message was sent by Atlassian JIRA (v6.3.15#6346)