[
https://issues.apache.org/jira/browse/BEAM-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855003#comment-15855003
]
ASF GitHub Bot commented on BEAM-1409:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/1931
[BEAM-1409] Check that Elements, Timers have permitted Timestamps
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Add a checkArgument to ImmutableListBundleFactory that elements must
be timestamped earlier than the maximum representable timestamp.
Add a checkArgument to TimerData that Timers must fire before the
maximum representable timestamp.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam checkArgument_not_past_infinity
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1931.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1931
----
commit ebc973254a8e85eb4e9476ed1778a068dd7436f8
Author: Thomas Groh <[email protected]>
Date: 2017-02-06T23:49:05Z
Check that Elements, Timers have permitted Timestamps
Add a checkArgument to ImmutableListBundleFactory that elements must
be timestamped earlier than the maximum representable timestamp.
Add a checkArgument to TimerData that Timers must fire before the
maximum representable timestamp.
----
> The DirectRunner should forbid elements outside of representable time.
> ----------------------------------------------------------------------
>
> Key: BEAM-1409
> URL: https://issues.apache.org/jira/browse/BEAM-1409
> Project: Beam
> Issue Type: Improvement
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
>
> This ensures that even if the timestamps are representable in Java, they are
> also representable within the model.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
