[
https://issues.apache.org/jira/browse/BEAM-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856297#comment-15856297
]
ASF GitHub Bot commented on BEAM-1332:
--------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/1936
[BEAM-1332] Cleanup files after the tests end
Snippet tests don't clean up the temporary files that are created these
changes should address that.
R: @aaltay PTAL
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam
BEAM-1332-clean_files_after_snippet_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1936.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1936
----
commit fad52f97c7455426145de6a6ba29f021d42dca2a
Author: Sourabh Bajaj <[email protected]>
Date: 2017-01-27T23:46:30Z
Cleanup files after the tests end
----
> Temporary files in snippet tests are not cleaned up
> ----------------------------------------------------
>
> Key: BEAM-1332
> URL: https://issues.apache.org/jira/browse/BEAM-1332
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Affects Versions: Not applicable
> Reporter: Sourabh Bajaj
> Assignee: Sourabh Bajaj
> Priority: Minor
> Fix For: Not applicable
>
>
> Files created in
> https://github.com/apache/beam/blob/python-sdk/sdks/python/apache_beam/examples/snippets/snippets_test.py#L426
> are not deleted at teardown.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
