[
https://issues.apache.org/jira/browse/BEAM-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856374#comment-15856374
]
ASF GitHub Bot commented on BEAM-1384:
--------------------------------------
GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/1937
[BEAM-1384] JmsIO: better errors during start, better testing
For BEAM-1384, the test has been failing because the error may be surfaced
in either
start() or close(), depending on execution path. The underlying bug is that
start
was implemented so that close might fail (this.connection would be set, but
this.connection.close would fail in a bad way).
Rewrite start() to fix the invariant needed by close() and also to provide
better error messages. Fixup the tests. Unfortunately, expectedException
doesn't
really support testing causes and nested caused, so the rewrite dropped its
use.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam jms-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1937.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1937
----
commit 522ca570e9556e41f84327adfe8f3fb1c96f47e6
Author: Dan Halperin <dhalp...@google.com>
Date: 2017-02-07T17:35:35Z
[BEAM-1384] JmsIO: better errors during start, better testing
For BEAM-1384, the test has been failing because the error may be surfaced
in either
start() or close(), depending on execution path. The underlying bug is that
start
was implemented so that close might fail (this.connection would be set, but
this.connection.close would fail in a bad way).
Rewrite start() to fix the invariant needed by close() and also to provide
better error messages. Fixup the tests. Unfortunately, expectedException
doesn't
really support testing causes and nested caused, so the rewrite dropped its
use.
----
> JmsIO postcommit failure: testAuthenticationWithBadPassword
> -----------------------------------------------------------
>
> Key: BEAM-1384
> URL: https://issues.apache.org/jira/browse/BEAM-1384
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Reporter: Kenneth Knowles
> Assignee: Daniel Halperin
>
> Postcommit failure here:
> https://builds.apache.org/job/beam_PostCommit_Java_MavenInstall/2517/org.apache.beam$beam-sdks-java-io-jms/testReport/junit/org.apache.beam.sdk.io.jms/JmsIOTest/testAuthenticationWithBadPassword/
> It seems to be looking for a message which is actually there but buried deep
> in the cause stack.
> Filing as minor, but if this recurs it should be moved up to Major or Blocker.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
