[
https://issues.apache.org/jira/browse/BEAM-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857136#comment-15857136
]
Eugene Kirpichov commented on BEAM-1417:
----------------------------------------
This might be not such a good idea since returning a Combine.Globally transform
allows the user to apply tweaks that this transform supports, e.g. withFanout()
and .withoutDefaults() and .asSingletonView(). Wrapping into a class makes
sense in case the transform's implementation could change, but in this case it
seems very unlikely.
> Count should comply with PTransform style guide
> -----------------------------------------------
>
> Key: BEAM-1417
> URL: https://issues.apache.org/jira/browse/BEAM-1417
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Eugene Kirpichov
> Assignee: Davor Bonaci
>
> Suggested change (backward-compatible): methods globally(), perKey(),
> perElement() should return respective transform classes - Count.Globally,
> Count.PerKey, Count.PerElement. (currently some of them return a PTransform
> which is actually a Combine - the suggestion is to wrap them into classes).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
