[
https://issues.apache.org/jira/browse/BEAM-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857177#comment-15857177
]
ASF GitHub Bot commented on BEAM-1353:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/1943
[BEAM-1353] Easy PTransform style guide compliance fixes
This leaves out the more complex / potentially-controversial ones.
R: @dhalperi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam style-guide
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1943.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1943
----
commit fc7602204b95a97fc4862398e44fd6e4299f8231
Author: Eugene Kirpichov <[email protected]>
Date: 2017-02-08T00:17:21Z
BEAM-1420 GroupByKey should comply with PTransform style guide
commit 406653829bb418b6e88ecb7a4e7145385351050e
Author: Eugene Kirpichov <[email protected]>
Date: 2017-02-08T00:18:26Z
BEAM-1421 Latest should comply with PTransform style guide
commit ded89d8437f4be3f60ba0f3291c1319608f91be0
Author: Eugene Kirpichov <[email protected]>
Date: 2017-02-08T00:24:08Z
BEAM-1423 Sample should comply with PTransform style guide
commit 4f94ff50dd6332d095bed5adfb1807e98faae983
Author: Eugene Kirpichov <[email protected]>
Date: 2017-02-08T00:34:31Z
BEAM-1424 ToString should comply with PTransform style guide
commit 88ac415dedec8b5e8e945a3c29b921eddcd1cfa3
Author: Eugene Kirpichov <[email protected]>
Date: 2017-02-08T00:39:33Z
BEAM-1426 SortValues should comply with PTransform style guide
commit de913746bf6a223bef9309e8033b3664e5b4d43f
Author: Eugene Kirpichov <[email protected]>
Date: 2017-02-08T00:44:40Z
BEAM-1416 Write transform should comply with PTransform style guide
commit c37d55045728d7bb1bfed07c04e02739b7730204
Author: Eugene Kirpichov <[email protected]>
Date: 2017-02-08T00:55:19Z
BEAM-1419 Flatten should comply with PTransform style guide
----
> Beam should comply with PTransform style guide
> ----------------------------------------------
>
> Key: BEAM-1353
> URL: https://issues.apache.org/jira/browse/BEAM-1353
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core, sdk-java-extensions, sdk-java-gcp, sdk-py
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
> Labels: backward-incompatible
>
> https://beam.apache.org/contribute/ptransform-style-guide/ is a collection of
> best practices for developing PTransform's.
> Some of these practices shaped up relatively recently, and some Beam
> transforms violate them, introducing inconsistency into Beam APIs and
> tempting new library writers and users into mimicking code that's best not
> mimicked.
> This is an umbrella bug for cleanups bringing individual Beam transforms in
> accordance with the style guide.
> Please file 1 bug per transform that needs to be fixed (e.g. "Bring KafkaIO
> in accordance with style guide"); in the bug, describe which aspects need to
> be fixed (e.g. "should use AutoValue; should explicitly specify type
> parameters; should not use Coders for serialization") and link it with the
> current bug.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
