[
https://issues.apache.org/jira/browse/BEAM-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858802#comment-15858802
]
ASF GitHub Bot commented on BEAM-759:
-------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/1956
[BEAM-759] Remove blocking dataflow runner
R: @aaltay PTAL
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-759-remove-blocking-runners
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1956.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1956
----
commit b61634b209b538c52a172c987f19a2e7d8cc0afd
Author: Sourabh Bajaj <[email protected]>
Date: 2017-02-09T00:55:01Z
Remove blocking dataflow runner
----
> PipelineResult needs waitToFinish() and cancel()
> ------------------------------------------------
>
> Key: BEAM-759
> URL: https://issues.apache.org/jira/browse/BEAM-759
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Ahmet Altay
> Assignee: Ahmet Altay
> Priority: Minor
> Labels: sdk-consistency
> Fix For: Not applicable
>
>
> Java SDK, added waitToFinish() and cancel() to the PipelineResults, and as a
> result were able to remove BlockingDataflowRunner.
> (See: https://issues.apache.org/jira/browse/BEAM-443)
> The same changes needs to happen in python sdk.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)